-
Notifications
You must be signed in to change notification settings - Fork 3
feat: initial gnap and http signatures implementation #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
feat: http signature client
…-python-sdk into ft/gnap-utils
Chore: Updated Readme Docs
@Tymmmy I have added some usage documentation in the README.md. Still adding more docs though. The current docs should give an idea of how I envisioned the client to be used. |
The integration test for requesting a grant is now passing. to run integration tests.
I registered a wallet , created keys and loaded it in privkey.pem.example for testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Did a quick first pass, will try setting up locally for next round of review.
thanks @sidvishnoi for these comments. I will address them ASAP. |
Some overall comments about this PR:
|
thanks @johngian for these comments.
|
@elijah0kello its not about having an overwhelming codebase. There is a purpose and value on having atomic commits. The PR at its current state (from a quick look) has 4+ commits that are about running unit tests and 3-4 commits only about updating docs, on top of that there is a bunch of merge commits from other repositories which don't bring much value in the context of the commit history. Also there is a commit that fixes a typo of a change introduced in this changeset. Regarding the http signatures lib i would defer to the folks from the organization to decide but if it was my decision i would rather have an implementation that is audited/vetted by the org or built internally just for the purpose of ILF projects. |
Install it in your project | ||
|
||
```bash | ||
pip install </path/to/>open-payments-python-sdk/dist/open_payments_sdk-0.1.0-py3-none-any.whl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have a poetry based setup, there is no need to point to a pinned version of the wheel file.
To use this sdk, you will first need to install it in your project. Currently you will need to build from source but once it is hosted on pypi you will be able to install it with pip | ||
|
||
```bash | ||
python3 -m pip install open-payments-python-sdk #currently not setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are running poetry install
why do you need to explicitly install the module?
I am happy, as long as we introduce CVE scanning to ensure the libraries are safe to use. I have left other comments on the PR. 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments, mostly regarding pip-audit
.
thanks @koekiebox for comments. I will address as advised. Especially the dependency auditing. |
Co-authored-by: Sid Vishnoi <[email protected]>
Co-authored-by: Sid Vishnoi <[email protected]>
Changes in this PR
Things to note
@Tymmmy @johngian please review
Authors
Run unit tests