Skip to content

Improve behavior over non-https connection #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isc-tleavitt opened this issue Jan 23, 2023 · 0 comments · Fixed by #233
Closed

Improve behavior over non-https connection #227

isc-tleavitt opened this issue Jan 23, 2023 · 0 comments · Fixed by #233
Assignees
Labels
customer Based on customer feedback (as opposed to something identified by developers) documentation Improvements or additions to documentation enhancement New feature or request

Comments

@isc-tleavitt
Copy link
Collaborator

isc-tleavitt commented Jan 23, 2023

Without this, VSCode webviews just won't work. (And they fail badly.)

Could also perhaps make this clearer in the settings / git webui pages themselves. Specifically: if you attempt to access one of these pages on non-localhost over an http connection, offer a link that opens in a new window and yell at the user for not using https.

Better yet: detect menu listing over Atelier APIs with insecure connection, yell at the user right in VSCode, and automatically open in a browser window (Action=3) rather than an iframe if it's not going to work.

@isc-tleavitt isc-tleavitt self-assigned this Jan 23, 2023
@isc-tleavitt isc-tleavitt added documentation Improvements or additions to documentation customer Based on customer feedback (as opposed to something identified by developers) enhancement New feature or request labels Jan 23, 2023
@isc-tleavitt isc-tleavitt changed the title Document requirement for https connection to non-localhost instances Improve behavior over non-https connection Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer Based on customer feedback (as opposed to something identified by developers) documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant