Skip to content

Set up default mappings with SourceControl.Git.Settings #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
isc-pbarton opened this issue Mar 24, 2023 · 2 comments
Closed

Set up default mappings with SourceControl.Git.Settings #250

isc-pbarton opened this issue Mar 24, 2023 · 2 comments
Assignees
@isc-pbarton
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
2023 Usability Im...

Comments

@isc-pbarton
Copy link
Collaborator

Say I am configuring an instance programmatically with a setup script using the SourceControl.Git.Settings API:

set settings = ##class(SourceControl.Git.Settings).%New()
do settings.%Save()

Most settings values are set to a default value, but the mappings are not set to anything. Instead I have to set each mapping individually on the Mappings property.
To make this more convenient we could check if there are any existing mappings configured. If not, set Mappings to the default values.
@isc-tleavitt
Copy link
Collaborator

Relates to #225 re: backward-compatibility "if no mappings are configured" - might make sense to tackle simultaneously.

@isc-tleavitt isc-tleavitt self-assigned this Apr 14, 2023
@isc-tleavitt isc-tleavitt added enhancement New feature or request good first issue Good for newcomers labels Apr 14, 2023
isc-rsaptars added a commit that referenced this issue Sep 13, 2023
@isc-rsaptars
fixed issue #250 -- Set up default mappings with SourceControl.Git.Se…
f0855e8 
…ttings
isc-tleavitt added a commit that referenced this issue Sep 14, 2023
@isc-tleavitt
Merge pull request #282 from intersystems/fix-default-mappings
84ea497 
fixed issue #250 -- Set up default mappings with SourceControl.Git.Settings
@isc-rsaptars
Copy link
Contributor

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isc-pbarton isc-pbarton

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
2023 Usability Improvements
Development

No branches or pull requests
3 participants
@isc-pbarton @isc-tleavitt @isc-rsaptars