Skip to content

Custom PullEventHandler lost when saving Git Project Settings #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
copperschnack opened this issue Jun 30, 2023 · 2 comments · Fixed by #289
Closed

Custom PullEventHandler lost when saving Git Project Settings #267

copperschnack opened this issue Jun 30, 2023 · 2 comments · Fixed by #289
Assignees
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers)

Comments

@copperschnack
Copy link

Steps to reproduce:

  • Specify custom pull event class extending SourceControl.Git.PullEventHandler.Default w/ some write output in OnPull() during
    d ##class(SourceControl.Git.API).Configure()

  • Pull change from git upstream to verify that the output is shown

  • Open Git > Settings and save

  • Pull other change from git upstream - custom pull handler is no longer in place

@isc-tleavitt isc-tleavitt self-assigned this Jun 30, 2023
@isc-tleavitt isc-tleavitt added bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers) labels Jun 30, 2023
@isc-tleavitt
Copy link
Collaborator

@copperschnack good find, thanks for reporting this.

@isc-tleavitt
Copy link
Collaborator

Solution: Settings UI needs to dynamically populate the dropdown based on existing subclasses of SourceControl.Git.PullEventHandler (see %Dictionary.ClassDefinition:SubclassOf) rather than being hardcoded to the two we ship.

@isc-rsaptars isc-rsaptars linked a pull request Sep 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants