Skip to content

Custom PullEventHandler lost when saving Git Project Settings #267

Closed
@copperschnack

Description

@copperschnack

Steps to reproduce:

  • Specify custom pull event class extending SourceControl.Git.PullEventHandler.Default w/ some write output in OnPull() during
    d ##class(SourceControl.Git.API).Configure()

  • Pull change from git upstream to verify that the output is shown

  • Open Git > Settings and save

  • Pull other change from git upstream - custom pull handler is no longer in place

Activity

self-assigned this
on Jun 30, 2023
added
bugSomething isn't working
customerBased on customer feedback (as opposed to something identified by developers)
on Jun 30, 2023
isc-tleavitt

isc-tleavitt commented on Jun 30, 2023

@isc-tleavitt
Collaborator

@copperschnack good find, thanks for reporting this.

isc-tleavitt

isc-tleavitt commented on Sep 21, 2023

@isc-tleavitt
Collaborator

Solution: Settings UI needs to dynamically populate the dropdown based on existing subclasses of SourceControl.Git.PullEventHandler (see %Dictionary.ClassDefinition:SubclassOf) rather than being hardcoded to the two we ship.

linked a pull request that will close this issueAdd custom pull handlers #289on Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingcustomerBased on customer feedback (as opposed to something identified by developers)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @copperschnack@isc-tleavitt@isc-rsaptars

    Issue actions

      Custom PullEventHandler lost when saving Git Project Settings · Issue #267 · intersystems/git-source-control