Studio: hanging on Git operations, Git menu very slow to load

[zdateh]

I am unable to practically use the Git menu in studio - doing operations like 'Fetch from Remote' just hangs Studio, with no error or anything in the console. Are there any ways I can diagnose what is causing this?

The Git menu is also slow to load - it takes around 5 seconds to display, which makes it pretty hard/annoying to use whilst working. I also fancy this extension has slowed down Studio in general.

By using a combination of what works and Git bash, I can do change control, but not really ideal!

[isc-tleavitt]

@zdateh are you set up with an https remote? This sounds like #235.

[zdateh]

@isc-tleavitt Hi, yes we're using an https remote (Azure dev ops). Would ssh remotes potentially help (that's the other option provided in Azure)?

re: #235 I haven't seen any credential checks coming up

[isc-tleavitt]

@zdateh yes, switching to ssh would fix the issue.

The problem is that the credential check is coming up in the background and hanging the process on the server. :(

[isc-tleavitt]

Closing this as a duplicate of #235

[zdateh]

Switching to SSH has indeed fixed my remotes issue - all git operations appear to succeed so far, thanks!

However it's still as slow in studio as before :( I am unsure what it could be doing in the background as git operations are near-instant from the command line, but as soon as I click on that Git menu, it's doing nothing for 5 seconds. Any ideas?

[zdateh]

Hi, could we please re-open this? We have been using SSH as requested but the menus and studio operation is still noticeably slower with Git extension active. e.g.:

• re-opening/closing studio with many routines/classes being edited takes over a minute.
• loading a routine/class takes 5-10 seconds

None of them dealbreakers but can be annoying whilst developing :)

Cheers

[isc-tleavitt]

@zdateh sure, happy to reopen given your observations.

Technically speaking (for whoever picks this up):
We run "git status" to see what's currently pending. There's some caching of the results built-in for rendering the menus (so that we don't re-run for each menu item), but not across operations (e.g., loading multiple tabs with different files in Studio). Load of a single class/routine taking 5-10 seconds is particularly unexpected.

@zdateh - if you could capture %SYS.MONLBL (RtnLine/Time/TotalTime) on SourceControl.Git.* for loading a single routine (which is taking 5-10 seconds) and attach as CSV that would be super helpful. I'm pretty sure the overhead will just be in the $zf(-100) calls, which perhaps we could look to reduce somehow, but it would be good just to be sure it's not something else/surprising.

[zdateh]

Thanks! Attached csv:
zcjb_sourcecontrol.csv

[isc-tleavitt]

@zdateh thank you, that's super helpful - the bottleneck isn't at all where I would have expected. (Which is why %SYS.MONLBL is so great.)

Top issues are:

Routine | Line | RtnLine | Time | TotalTime | Code
SourceControl.Git.Extension.1 | 41 | 3 | 0.000023 | 7.5793 | do ##class(SourceControl.Git.Change).RefreshUncommitted(,,.files)
SourceControl.Git.Change.1 | 1042 | 6820 | 0.007226 | 7.011443 | set InternalName = ##class(SourceControl.Git.Utils).NameToInternalName(filename,0,0)
SourceControl.Git.Utils.1 | 989 | 6832 | 0.04499 | 5.520985 | set sc=$system.OBJ.Load(Name,"-d",,.outName,1)
SourceControl.Git.Utils.1 | 1459 | 13694 | 0.012658 | 1.299256 | If ##class(%Library.RoutineMgr).UserType(InternalName,.docclass,.doctype) {

We can definitely optimize these things.

[isc-tleavitt]

This is fixed via #318.