Skip to content

Better API for argument handling that reads command as array #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
isc-hwojnick opened this issue Jul 25, 2024 · 1 comment · Fixed by #439
Closed

Better API for argument handling that reads command as array #437

isc-hwojnick opened this issue Jul 25, 2024 · 1 comment · Fixed by #439
Assignees
@isc-hwojnick
Labels
enhancement New feature or request
Milestone
Summer 2024 Impro...

Comments

@isc-hwojnick
Copy link
Contributor

Argument handling code for POST to /git is hard to work with. This is posing an issue particularly with handling commit messages with double quotes.
@isc-hwojnick isc-hwojnick added this to the Summer 2024 Improvements milestone Jul 25, 2024
@isc-hwojnick isc-hwojnick self-assigned this Jul 25, 2024
@isc-tleavitt isc-tleavitt added the enhancement New feature or request label Jul 26, 2024
@isc-tleavitt
Copy link
Collaborator

isc-tleavitt commented Jul 26, 2024 •
edited
Loading

This is worded as an enhancement but really is needed for the real fix to #433 - should go in 2.4.1

@isc-hwojnick isc-hwojnick mentioned this issue Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isc-hwojnick isc-hwojnick

Labels
enhancement New feature or request
Projects
None yet
Milestone
Summer 2024 Improvements
Development

Successfully merging a pull request may close this issue.

New array based git API command for webui intersystems/git-source-control
2 participants
@isc-tleavitt @isc-hwojnick