Skip to content

Prevent Sync / WebUI from closing when launched from Production Configuration page and reload is triggered in background due to timer #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isc-tleavitt opened this issue Oct 11, 2024 · 1 comment · Fixed by #563
Assignees
Labels
enhancement New feature or request upstream Full/ideal correction requires changes to upstream dependencies (e.g., IRIS) usability

Comments

@isc-tleavitt
Copy link
Collaborator

Right now this is very jarring and a pain in the neck.

There's a related upstream issue (internal ref: DP-424937) but I think git-source-control could do some clever things around this with either (a) a lock on the CSP session (which is a blunt instrument and possibly problematic) or (b) communication back to the parent frame.

@isc-tleavitt isc-tleavitt added enhancement New feature or request upstream Full/ideal correction requires changes to upstream dependencies (e.g., IRIS) usability labels Oct 11, 2024
@isc-tleavitt isc-tleavitt added this to the Q3/Q4 2024 Targets milestone Oct 11, 2024
@isc-tleavitt
Copy link
Collaborator Author

Possible simple approach to (b): attempt to get the old value of window.parent.zenPage.enableAutoRefresh; if successful and true, set to false and set back to true in onbeforeunload eventhandler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upstream Full/ideal correction requires changes to upstream dependencies (e.g., IRIS) usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant