-
Notifications
You must be signed in to change notification settings - Fork 8
fix: production config page no longer closes UIs #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
==========================================
+ Coverage 26.25% 29.27% +3.02%
==========================================
Files 18 18
Lines 2678 3440 +762
==========================================
+ Hits 703 1007 +304
- Misses 1975 2433 +458 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this out on HCC, and closing the UI after checkout does not cause a reload of production. Is the user supposed to reload themselves or do we expect the reload to occur by itself?
@isc-etamarch I observed the production reloading when I tried to do something on it, rather than via timer. I'll double check in HCC. In case it's relevant, which browser were you using? |
I am on edge (the browser). It reloads after an attempted change, but for changes such as actor pool size it allows you to save the changes before the reload happens (change persists after reload). Have not tested out making a change to non-existent / removed item yet |
This is cleaner, and also means that we refresh automatically after closing the page if needed!
@isc-etamarch I found a much cleaner approach; also loaded this to our HCC if you want to test there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very smooth transition!
This is a nice simple approach and it's working great in my testing locally.
Fixes #542