Skip to content

fix: production config page no longer closes UIs #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

isc-tleavitt
Copy link
Collaborator

@isc-tleavitt isc-tleavitt commented Oct 22, 2024

This is a nice simple approach and it's working great in my testing locally.

Fixes #542

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 29.27%. Comparing base (f2ef459) to head (7fc8d0f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cls/SourceControl/Git/Utils.cls 0.00% 16 Missing ⚠️
cls/SourceControl/Git/StreamServer.cls 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
+ Coverage   26.25%   29.27%   +3.02%     
==========================================
  Files          18       18              
  Lines        2678     3440     +762     
==========================================
+ Hits          703     1007     +304     
- Misses       1975     2433     +458     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@isc-etamarch isc-etamarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out on HCC, and closing the UI after checkout does not cause a reload of production. Is the user supposed to reload themselves or do we expect the reload to occur by itself?

@isc-tleavitt
Copy link
Collaborator Author

@isc-etamarch I observed the production reloading when I tried to do something on it, rather than via timer. I'll double check in HCC. In case it's relevant, which browser were you using?

@isc-etamarch
Copy link
Collaborator

isc-etamarch commented Oct 22, 2024

@isc-etamarch I observed the production reloading when I tried to do something on it, rather than via timer. I'll double check in HCC. In case it's relevant, which browser were you using?

I am on edge (the browser). It reloads after an attempted change, but for changes such as actor pool size it allows you to save the changes before the reload happens (change persists after reload). Have not tested out making a change to non-existent / removed item yet

This is cleaner, and also means that we refresh automatically after closing the page if needed!
@isc-tleavitt
Copy link
Collaborator Author

@isc-etamarch I found a much cleaner approach; also loaded this to our HCC if you want to test there.

Copy link
Collaborator

@isc-etamarch isc-etamarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very smooth transition!

@isc-tleavitt isc-tleavitt merged commit bb716fb into main Oct 22, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the fix-542 branch October 22, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants