Skip to content

Dots (.) are being escaped automatically on Schema exports (and likely other files) #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CraigRegester opened this issue Dec 3, 2021 · 6 comments · Fixed by #100
Closed
Assignees
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers)

Comments

@CraigRegester
Copy link
Contributor

This is happening both with git-source-control and the InterSystems Objectscript Extension (not using ISFS).

If I have a schema named FAEPIC_2.3.1.HL7 and Add (ISFS) or Export (non-ISFS), I get this:

InterSystems ObjectScript Extension Export:
export "FAEPIC_2.3.1.HL7" as "c:\Users\142990\MyDev\ISC-HealthShare-UCR\FALIB\src\FAEPIC_2\3\1.hl7" - Success

InterSystems git-source-control Export:
new file:   INTGBUS/hl7/FAEPIC_2/3/1.cls

Can we not escape the dots on schema exports? Creates a nasty folder structure.

@isc-tleavitt
Copy link
Collaborator

@isc-svelury if the type of the file is "Other" (e.g., in the old Studio view - that is, not a class/routine/include but instead a "user type" handled by some subclass of %Studio.AbstractDocument), we should preserve the name when exporting.

Note that if the package manager is in use all of this should just work; we're only interested in fixing the case where it isn't in use.

@isc-tleavitt isc-tleavitt added bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers) labels Dec 7, 2021
@isc-tleavitt
Copy link
Collaborator

Minor change in direction here: the dots-to-folders behavior can be suppressed via the "NoFolders" subscript under the file type. We should support this via the UI and set reasonable defaults for all user types. (BPL/DTL should continue to export as classes.)

@CraigRegester
Copy link
Contributor Author

I think I get what you're saying - the filename itself can respect the NoFolders option but I can still folder my schemas together if I want right? E.g., extension HL7 goes into /hl7 folder so /hl7/2.3.1.hl7

@isc-tleavitt
Copy link
Collaborator

@CraigRegester that's correct.

@isc-tleavitt
Copy link
Collaborator

isc-tleavitt commented Dec 8, 2021

Relevant bit of code: https://github.com/intersystems/git-source-control/blob/main/cls/SourceControl/Git/Utils.cls#L1287

@CraigRegester
Copy link
Contributor Author

Perfect, thanks @isc-tleavitt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants