Skip to content

Fix workspace operations for filenames with spaces #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2022
Merged

Fix workspace operations for filenames with spaces #181

merged 2 commits into from
Apr 4, 2022

Conversation

isc-svelury
Copy link
Contributor

  1. Fixed the check for whether the current user edited a certain file. It failed with filenames which had spaces in them because those strings were quoted and the string used for comparison was not.
  2. Fixed the way we get a list of files, upon which the selected operation occurs.

Closes #178

@isc-svelury isc-svelury added the bug Something isn't working label Apr 4, 2022
@isc-svelury isc-svelury requested a review from isc-tleavitt April 4, 2022 16:05
@isc-tleavitt isc-tleavitt merged commit 11c30d9 into main Apr 4, 2022
@isc-tleavitt isc-tleavitt deleted the space-fix-working-copy branch April 4, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isc-tleavitt isc-tleavitt isc-tleavitt approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workspace operations don't work reliably if filenames have spaces
2 participants
@isc-svelury @isc-tleavitt