Skip to content

Simplify pull and configuration #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 18, 2023
Merged

Conversation

isc-tleavitt
Copy link
Collaborator

@isc-tleavitt isc-tleavitt commented May 11, 2023

(Details in changelog.)

Fixes #234
Fixes #237
Fixes #33
Fixes #254
Fixes #229

@isc-tleavitt isc-tleavitt requested a review from isc-pbarton May 11, 2023 12:15
@isc-tleavitt
Copy link
Collaborator Author

@isc-pbarton this is a working draft... scope crept a bit. :)

@isc-tleavitt
Copy link
Collaborator Author

@isc-pbarton the last bit of work I intend for this is done, good to review now.

Copy link
Collaborator

@isc-pbarton isc-pbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me! Just added one suggestion, a comment explaining what the work queue manager is for here.

@isc-tleavitt isc-tleavitt merged commit fed34cc into main May 18, 2023
@isc-tleavitt isc-tleavitt deleted the simplify-pull-and-configuration branch May 18, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment