Compile items after Import All #368
Conversation
|
Please make this configurable. The codebase I work with requires some classes to be compiled in a particular order on first import for reasons that are not practical to address in the short term. I am concerned that this will cause problems for us. |
|
@isc-pbarton the point @raymond-rebbeck raises is fair - let's make this configurable, but we want to default to compiling (particularly for the sake of less-technical interop users who wouldn't necessarily understand the implications). |
cls/SourceControl/Git/Utils.cls
Outdated
| @@ -1230,7 +1230,7 @@ ClassMethod ImportItem(InternalName As %String, force As %Boolean = 0, verbose A | |||
| if ($extract(InternalName, 1) = "/"){ | |||
| set sc = ..ImportCSPFile(InternalName) | |||
| } else{ | |||
| set sc = $system.OBJ.Load(filename,"-l-d") | |||
There was a problem hiding this comment.
Interesting that we were using -l - I wonder if there was a reason for this. I agree that displaying output is reasonable, for sure.
Question - what's the behavior if a single item fails to load/compile?
A better architecture here would be to maintain a list of things that were loaded by specific calls to ImportItem and then compile all of them at the same time after all have been loaded. As written this is likely to hit dependencies (especially on initial load); with compilation at the end it at least should be possible for a developer to fix compilation dependencies with the right values for System, CompileAfter, DependsOn, etc.
There was a problem hiding this comment.
Note from discussion today: just use PullEventHandler
…t-source-control into compile-on-import
This reverts commit 9718793.
Fixes #362