Skip to content

Sync with iris for all local repo changes #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 25, 2024
Merged

Conversation

isc-hwojnick
Copy link
Contributor

@isc-hwojnick isc-hwojnick commented Jun 24, 2024

Anytime a git command occurs that adds or deletes files, IRIS will sync with the changes to the project

Fixes #153

@isc-hwojnick isc-hwojnick changed the title Fixes Issue #153 Sync iris codebase change Fixes #153 Sync iris codebase change Jun 24, 2024
@isc-hwojnick isc-hwojnick requested a review from isc-pbarton June 24, 2024 14:05
Copy link
Collaborator

@isc-pbarton isc-pbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also test using the "Git Pull" page in the UI to pull changes please (that is, the page you get to if you follow the "Git Pull" link in the Favorites in the SMP). I'm seeing unexpected behavior with that page but I'm not sure yet if it's related to this change.

@isc-hwojnick isc-hwojnick requested a review from isc-pbarton June 24, 2024 16:31
@isc-tleavitt isc-tleavitt self-requested a review June 24, 2024 16:56
@isc-tleavitt isc-tleavitt changed the title Fixes #153 Sync iris codebase change Sync with iris for all local repo changes Jun 24, 2024
@isc-hwojnick isc-hwojnick requested a review from isc-pbarton June 25, 2024 13:46
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SourceControl.Git.API:Pull is part of the API for git-source-control. We shouldn't/can't just remove it.

@isc-hwojnick isc-hwojnick requested a review from isc-pbarton June 25, 2024 16:39
@isc-hwojnick isc-hwojnick requested a review from isc-pbarton June 25, 2024 17:47
@isc-tleavitt isc-tleavitt merged commit 44dd368 into main Jun 25, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the sync-iris-codebase-change branch June 25, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync code with IRIS after all codebase changes
3 participants