Skip to content

Instance wide uncommitted queue #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 27, 2024
Merged

Instance wide uncommitted queue #436

merged 12 commits into from
Sep 27, 2024
+97 −3

Conversation

isc-hwojnick
Copy link
Contributor

Fixes #370

isc-tleavitt
isc-tleavitt requested changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One really tiny nitpick, otherwise good.

isc-tleavitt
isc-tleavitt requested changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nit, and a request: please test this as a user with just %Developer to make sure it all works properly without doing extra SQL security work.

@isc-tleavitt
Copy link
Collaborator

Can retarget this to main at this point.

@isc-hwojnick isc-hwojnick changed the base branch from next-release to main August 7, 2024 13:24
@isc-pbarton isc-pbarton self-assigned this Aug 20, 2024
@isc-pbarton isc-pbarton marked this pull request as draft August 20, 2024 19:19
@isc-pbarton
fixes to PROTECT and other errors
4c2135b
@isc-pbarton
Improvements to instance-wide uncommitted queue
Loading
Loading status checks…
e96bd1f 
Editing the file will get rid of the warning. Also, warning can be disabled in configuration.
@isc-pbarton isc-pbarton marked this pull request as ready for review August 21, 2024 15:50
@isc-pbarton
Copy link
Collaborator

I made some fixes to get this working with %Developer roles, and a couple other minor improvements:

  • The alert will no longer show up if I have the item edited in the current namespace
  • There's now a setting in Configure I can use to turn off the alerts entirely

isc-tleavitt
isc-tleavitt requested changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nitpicks and one SQL security question.

@isc-etamarch
Make sure we are using correct namespaces
Loading
Loading status checks…
633114d
isc-tleavitt
isc-tleavitt requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bit of housekeeping in CHANGELOG.md and module.xml needed here, then good to go.

@isc-tleavitt isc-tleavitt merged commit 313b11b into main Sep 27, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the instance-wide-uncommitted-queue branch September 27, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isc-tleavitt isc-tleavitt

@isc-pbarton isc-pbarton

Assignees

@isc-etamarch isc-etamarch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instance-wide awareness of uncommitted queue for concurrency
4 participants
@isc-hwojnick @isc-tleavitt @isc-pbarton @isc-etamarch