Skip to content

Process input to Configure() #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Process input to Configure() #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e11692f
Process input to Configure
isc-etamarch Oct 22, 2024
302efe4
Merge branch 'main' into issue-356
isc-etamarch Oct 22, 2024
f056c2f
Simplified trimming leading spaces
isc-etamarch Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fix "Home" navigation to point to current namespace (#548)
- Force export of item if it has been modified (#354)
- Production configuration page no longer closes Sync/WebUI when operations there change the production (#542)
- Remove leading/trailing spaces from input to Configure() (#356)

## [2.6.0] - 2024-10-07

Expand Down
2 changes: 2 additions & 0 deletions cls/SourceControl/Git/Settings.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ ClassMethod Configure() As %Boolean [ CodeMode = objectgenerator ]
do %code.WriteLine(" set valid = 0")
do %code.WriteLine(" while ('valid) {")
do %code.WriteLine(" set response = ##class(%Library.Prompt).GetString("_promptQuoted_",.value,,,,"_defaultPromptFlag_")")
do %code.WriteLine(" set value = $zstrip(value,""<>W"")")
do %code.WriteLine(" set status = inst.ConfigureBinPath(.value)")
do %code.WriteLine(" if (status) { set valid = 1 }")
do %code.WriteLine(" }")
Expand All @@ -206,6 +207,7 @@ ClassMethod Configure() As %Boolean [ CodeMode = objectgenerator ]
do %code.WriteLine(" set response = ##class(%Library.Prompt).GetString("_promptQuoted_",.value,,,,"_defaultPromptFlag_")")
}
do %code.WriteLine(" if response '= $$$SuccessResponse { quit 0 }")
do %code.WriteLine(" set value = $zstrip(value,""<>W"")")
do %code.WriteLine(" set inst."_property_" = value")

}
Expand Down
Loading