Skip to content

Added pull event handler for full import #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

isc-pbarton
Copy link
Collaborator

Resolves #619

FullLoad handler will call Import All with Force. Import All handles deletes by deleting any items that exist in the Embedded Git timestamp cache but do not exist in the Git repository. I think that is the level of smartness for deletes we want in this case: if an item was deployed or edited with Embedded Git, it will get deleted properly; if it exists on the server for some other reason, it will not get deleted.

Changes here got tangled up with #469, so I'm going to mark this as a draft until production decomposition is merged and then rebase it onto main.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 41.81%. Comparing base (ebf933e) to head (09c839a).

Files with missing lines Patch % Lines
cls/SourceControl/Git/Utils.cls 0.00% 5 Missing ⚠️
...ls/SourceControl/Git/PullEventHandler/FullLoad.cls 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #638      +/-   ##
==========================================
- Coverage   41.84%   41.81%   -0.03%     
==========================================
  Files          22       23       +1     
  Lines        3016     3018       +2     
==========================================
  Hits         1262     1262              
- Misses       1754     1756       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Base automatically changed from production-change-control to main November 18, 2024 18:40
@isc-pbarton isc-pbarton marked this pull request as ready for review November 19, 2024 17:33
@isc-tleavitt isc-tleavitt merged commit def4a75 into main Nov 20, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the full-load-handler branch November 20, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull event handler for full import
3 participants