Skip to content

API for loading decomposed productions #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2025
Merged

API for loading decomposed productions #683

merged 3 commits into from
Jan 17, 2025

Conversation

isc-pbarton
Copy link
Collaborator

Resolves #670

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.90%. Comparing base (4f1f989) to head (2ddb19a).

Files with missing lines Patch % Lines
cls/SourceControl/Git/API.cls 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
+ Coverage   40.50%   40.90%   +0.40%     
==========================================
  Files          23       23              
  Lines        3145     3146       +1     
==========================================
+ Hits         1274     1287      +13     
+ Misses       1871     1859      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - need to decide what to do with 2.9.1 and its changes though. Is that just 2.10.0 or do we want a bugfix release? Thoughts?

@isc-pbarton
Copy link
Collaborator Author

None of the bugs fixed in 2.9.1 were introduced in 2.9.0, so my inclination would be to roll those changes into 2.10.0

@isc-pbarton isc-pbarton merged commit 46c08f0 into main Jan 17, 2025
2 checks passed
@isc-pbarton isc-pbarton deleted the cd-decomp branch January 31, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support continuous deployment of decomposed production items
3 participants