Skip to content

Added revert / reset Head #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Added revert / reset Head #691

merged 4 commits into from
Jan 22, 2025

Conversation

isc-etamarch
Copy link
Collaborator

Addresses #586

@isc-etamarch isc-etamarch linked an issue Jan 17, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@46c08f0). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #691   +/-   ##
=======================================
  Coverage        ?   40.90%           
=======================================
  Files           ?       23           
  Lines           ?     3146           
  Branches        ?        0           
=======================================
  Hits            ?     1287           
  Misses          ?     1859           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isc-etamarch
Copy link
Collaborator Author

@isc-tleavitt / @isc-pbarton Could you review the description text to make sure that it sounds correct. Also, should we have another confirmation dialog after the revert type has been chosen?

Description Text:
'There are a few options available to revert the previous commit. Please read the description carefully to make sure you choose the correct option.

Revert: git revert --no-commit - This will create a new change, which will be the reversal of the previous commit. 'It will not be automatically committed, so you can inspect/modify/combine the changes with others before you commit.

Hard Reset: git reset --hard HEAD~1 - This will delete the previous commit entirely, and reset you to a state before the commit. WARNING: This will also delete all uncommitted changes, so make sure you have no changes left before attempting this operation.'

@isc-tleavitt
Copy link
Collaborator

@isc-tleavitt / @isc-pbarton Could you review the description text to make sure that it sounds correct. Also, should we have another confirmation dialog after the revert type has been chosen?

Description Text: 'There are a few options available to revert the previous commit. Please read the description carefully to make sure you choose the correct option.

Revert: git revert --no-commit - This will create a new change, which will be the reversal of the previous commit. 'It will not be automatically committed, so you can inspect/modify/combine the changes with others before you commit.

Hard Reset: git reset --hard HEAD~1 - This will delete the previous commit entirely, and reset you to a state before the commit. WARNING: This will also delete all uncommitted changes, so make sure you have no changes left before attempting this operation.'

I think this is good.

@isc-etamarch isc-etamarch marked this pull request as ready for review January 22, 2025 19:05
@isc-etamarch isc-etamarch merged commit d2fba37 into main Jan 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to undo commits in the Git WebUI
3 participants