Skip to content

Settings file imports before everything else #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

isc-pbarton
Copy link
Collaborator

Closes #697
Fix applies to both incremental and full load handlers, as well as Import All.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.99%. Comparing base (d2fba37) to head (a7fa732).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
+ Coverage   40.89%   40.99%   +0.10%     
==========================================
  Files          23       23              
  Lines        3157     3161       +4     
==========================================
+ Hits         1291     1296       +5     
+ Misses       1866     1865       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isc-tleavitt isc-tleavitt merged commit b29baf0 into main Jan 31, 2025
2 checks passed
@isc-tleavitt isc-tleavitt deleted the import-settings-first branch January 31, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load configuration file before anything else
3 participants