Skip to content

Pull request for Issue 709 add locking branch to settings #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 11, 2025
Merged

Conversation

isc-ksaduest
Copy link
Collaborator

New toggle for "lock branch" to prevent branch switching for namespace.

@isc-ksaduest isc-ksaduest requested a review from isc-pbarton April 8, 2025 13:49
@isc-pbarton isc-pbarton changed the base branch from main to workflow April 8, 2025 18:56
@isc-pbarton isc-pbarton changed the base branch from workflow to main April 8, 2025 18:57
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 41.24%. Comparing base (50c83a4) to head (7f2b6ff).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
cls/SourceControl/Git/Extension.cls 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
- Coverage   41.28%   41.24%   -0.04%     
==========================================
  Files          24       24              
  Lines        3183     3188       +5     
==========================================
+ Hits         1314     1315       +1     
- Misses       1869     1873       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@isc-pbarton isc-pbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple code style nitpicks, otherwise looks good to me

@isc-ksaduest isc-ksaduest requested a review from isc-pbarton April 8, 2025 20:32
Copy link
Collaborator

@isc-pbarton isc-pbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more thing I missed on this pull request. Can you add a line in the CHANGELOG.md saying this feature was added please?

@isc-pbarton isc-pbarton dismissed their stale review April 11, 2025 14:25

Changelog entry was added

@isc-pbarton isc-pbarton merged commit e1584c6 into main Apr 11, 2025
2 checks passed
@isc-pbarton isc-pbarton deleted the Issue-#709 branch April 11, 2025 14:27
@isc-pbarton isc-pbarton linked an issue Apr 11, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow locking branch in protected namespaces
3 participants