Git add packages #79
Merged
Git add packages #79
+47
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isc-svelury this looks good. Can you file an issue report on vscode-objectscript re: consistency with studio in passing .pkg to extensions and mention this issue there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding packages to source control now works as expected. Closes #71
Known bug/potential improvement:
Currently, VS Code does not pass package names with the
.pkgextension. So to check if a package name is passed, we look for classes in the package. If there are no classes in the package, then the package will not be recognized and this solution will not work in VS Code. It will still work on Studio though.