Skip to content

compatibility fix for IE + minor bugfix #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2021
Merged

compatibility fix for IE + minor bugfix #83

merged 1 commit into from
Dec 1, 2021
+18 −4

Conversation

isc-svelury
Copy link
Contributor

@isc-svelury isc-svelury commented Dec 1, 2021 •
edited
Loading

  1. Default parameters don't work on IE. Fixed that by setting the variable if it is undefined.
  2. self.cancel() was not being called in cancelByAvailability(), so changes that did not need a confirmation from the user did not get cancelled.

@isc-svelury isc-svelury mentioned this pull request Dec 1, 2021
Merged
@isc-tleavitt isc-tleavitt merged commit 7b1433b into main Dec 1, 2021
@isc-tleavitt isc-tleavitt deleted the queue-filter-minor-fixes branch December 1, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isc-tleavitt isc-tleavitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@isc-svelury @isc-tleavitt