Skip to content

[flight_planning] Add RID-relevant information to flight planning interface #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BenjaminPelletier
Copy link
Member

Currently, we have two different interfaces for actuating flight-related activities on systems under test: the rid injection interface allows us to "inject" a flight for the purpose of remote ID testing, and the flight_planning interface allows us to originate a flight for other flight planning purposes. This can be problematic for systems which perform multiple UTM functions in response to a single user interface, however, as they will need to implement two different interfaces and each interface may not specify a sufficient amount of information for the flight.

This PR attempts to move toward addressing this issue by adding RID-relevant information to the flight planning interface. In the future, we can allow USSs to use either the rid injection interface or the flight_planning interface to "inject" RID flights (in the same way we support the deprecated scd interface alongside the flight_planning interface), which will then allow us to gracefully deprecate the rid injection interface entirely (the rid observation interface will remain relevant).

The information in this PR is intended to cover all the information in the rid injection interface, but not necessarily use the same format. Instead, it attempts to capture the information that might be provided/necessary from a user of a USS's system if that USS were performing remote ID. To this end, three groups of information are added to a FlightPlan:

  • Identity of the flight (added directly to BasicFlightPlanInformation)
  • Information about the UA/UAS (added as a new uas field with information defined in uas.yaml)
  • Information about the remote pilot/operator (added as a new operator field with information defined in operator.yaml)

Copy link

@mickmis mickmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have some questions about some things I don't understand but seem intended.

Comment on lines +15 to +17
message:
description: Message presented to the user, description of notification, or other means of helping identify the nature of the notification, for the purpose of increased readability of test reports.
type: string
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intended? It is not included in the PR description.

Although checking injection.yaml it is probably intended.

type: string
example: INTCJ123-4567-890
default: ''
registration_numbers:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why this is enabling multiple registration IDs? While the original UASID schema only enables one.

type: string
example: N
default: ''
type:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be an addition compared to the original UASID schema. Is this required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants