[tooling] Add pre-commit #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Formating and typing is verified by a CI job, however if you want to automaticaly check your code on each commit, this projet use [pre-commit](https://pre-commit.com/) | ||
|
|
||
| Install the tool as you want/your operating system want and run `pre-commit install` to add it to your local git hooks. |
There was a problem hiding this comment.
I think it's important to be able to evaluate on-demand without installing as a git hook; is the below correct?
Suggested change
| Install the tool as you want/your operating system want and run `pre-commit install` to add it to your local git hooks. | |
| Install the tool as you want/your operating system wants and run `pre-commit install` to add it to your local git hooks, or run `pre-commit run --all-files` to run without installing as a git hook. |
There was a problem hiding this comment.
Yes, but I as more seeing pre-commit as a "shield" for commits, when you want to run it "normally", I would suggest to use usual uv run commands (that are not documented).
Having different methods of invocation shouldn't be an issue except for version management (updated in lock file but not in pre-commits). So would it be better with a make file like others projects and pre-commits running it? It's more 'heavily', but we can version (and tooling) guaranteed :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should simply development as thoses are quick and since there are no Makefile helpers ;)