[tooling] Switch to ruff #1096
Open
[tooling] Switch to ruff #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-glu
force-pushed
the
ruff
branch
4 times, most recently
from
2546719 to
55e4d58
Compare
the-glu
commented
Aug 7, 2025
| @@ -6,7 +6,6 @@ | |||
| import flask | |||
| from implicitdict import ImplicitDict | |||
| from loguru import logger | |||
| from uas_standards.astm.f3411.v19.api import ErrorResponse | |||
There was a problem hiding this comment.
Redefined bellow. I assumed this file version is the one needed ? (message not optional here)
the-glu
commented
Aug 7, 2025
| @@ -42,7 +42,7 @@ | |||
| ) | |||
| from uas_standards.astm.f3548.v21.constants import Scope | |||
|
|
|||
| from monitoring.monitorlib import fetch, infrastructure | |||
There was a problem hiding this comment.
defined bellow from fetch.scd (and use scd methods in the file)
the-glu
commented
Aug 7, 2025
| @@ -45,7 +45,7 @@ def sub_get_query( | |||
| if not fetched_sub.success: | |||
| check.record_failed( | |||
| summary="Subscription query failed", | |||
| details=f"Failed to query subscription {sub_id} referenced by oid {self._oir_a_id} with code {fetched_sub.response.status_code}. Message: {fetched_sub.error_message}", | |||
There was a problem hiding this comment.
_oir_a_id is defined in class OIRImplicitSubHandling(TestScenario), I did assumed that the scenario variable
the-glu
commented
Aug 7, 2025
| @@ -1128,7 +1128,6 @@ def check_sub_not_none(oir): | |||
| check.record_failed( | |||
| summary="OIR not attached to any subscription", | |||
| details="OIR is not attached to any subscription, when a request for an implicit subscription was made.", | |||
| query_timestamps=[mutate_q.timestamp], | |||
There was a problem hiding this comment.
probably a copy-paste error from others similar methods, I did assume there are no query there.
the-glu
commented
Aug 7, 2025
| @@ -39,7 +39,7 @@ def run(self, context): | |||
| if not reports: | |||
| self.record_note( | |||
| "Skip reason", | |||
| f"Nominal behavior test scenario report could not be found for any of the scenario types {', '.join(SCENARIO_TYPES)}", | |||
There was a problem hiding this comment.
Scenario type seems to be a find_test_scenario_reports parameter, who is fixed to NominalBehavior here. Since 'Nominal behavior' is already in the text I just removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follow #1094
This replace black and isort by ruff.
For now, it use the default ruff configuration + isort. I do plan to add more rules incrementally when they are useful (e.g. pyupgrade) in separate PR to minimize changes.
It's spited in 3 commits:
I also had to apply manual fixes for import (in the second commit) dues to some strange imports of modules / submodules, making some undetected and ruff removing them, but they are 1-1 style-only changes like the rest of the commit.
Mostly tested by the fact that tests are still passing, so parts tests are not done should probably be checked carefully.