[local-env] improve compatibility with different local dev environments #1128
Conversation
|
For the virtual env part, I would leave it to |
I've been relying on venv because it's the default with my IDE and have not switched yet. It's a good reason to switch, but we may want to consider other developers in this situation? Note: alternatively we can mention this in the release notes? edit: got rid of my venv and properly enabled |
Shastick
force-pushed
the
widen-env-compatibility
branch
from
28bb1a5 to
6f756b9
Compare
Makefile
Outdated
| docker run --rm -u ${USER_GROUP} -v "$(CURDIR):/app" -w /app interuss/monitoring uv run ruff format --check || (echo "Linter didn't succeed. You can use the following command to fix python linter issues: make format" && exit 1) | ||
| docker run --rm -u ${USER_GROUP} -v "$(CURDIR):/app" -w /app interuss/monitoring uv run ruff check || (echo "Linter didn't succeed. You can use the following command to fix python linter issues: make format" && exit 1) | ||
| sha256sum .basedpyright/baseline.json > /tmp/baseline-before.hash | ||
| shasum -a 256 .basedpyright/baseline.json > /tmp/baseline-before.hash |
There was a problem hiding this comment.
nit: LLM recommends -b also to future-proof against system differences in text encoding or end-of-line differences.
Shastick
force-pushed
the
widen-env-compatibility
branch
from
6f756b9 to
2ff43f0
Compare
This PR improves general compatibility & usability of the interuss/monitoring repository by:
venvto .dockerignore, for any one using a local virtualenv that might live invenvsha256sum(absent from OS X) withsha -a 256, which should work on both OS X and most linux environmentsvenvand.venvfrom thebasedpyrightconfiguration (otherwise they get picked up and linted, which is both useless AND hellishly slow)@the-glu you may want to confirm I'm not breaking any of your intentions here! :)