Add logical NOT support #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MLSTRM Thank you for opening a PR! Can you, please, run |
igdianov
force-pushed
the
add-logical-not-support
branch
from
fe2a2da to
c945a99
Compare
igdianov
requested changes
Aug 13, 2024
...src/main/java/com/introproventures/graphql/jpa/query/schema/impl/GraphQLJpaQueryFactory.java
Show resolved
Hide resolved
MLSTRM
force-pushed
the
add-logical-not-support
branch
from
c945a99 to
f244950
Compare
MLSTRM
force-pushed
the
add-logical-not-support
branch
from
f244950 to
59bd15c
Compare
igdianov
approved these changes
Aug 28, 2024
|
LGTM. Thank you for the contribution! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #243
Still testing this implementation some more on my own end within the projects I have just to confirm its doing exactly what I would expect, but the initial unit test results are promising.