Skip to content

Conversation

igdianov
Copy link
Collaborator

fixes #72

@igdianov igdianov self-assigned this Mar 11, 2019
@igdianov igdianov added the bug label Mar 11, 2019
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #88 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #88      +/-   ##
============================================
- Coverage     62.52%   62.51%   -0.01%     
  Complexity      314      314              
============================================
  Files            32       32              
  Lines          1900     1905       +5     
  Branches        286      286              
============================================
+ Hits           1188     1191       +3     
- Misses          585      587       +2     
  Partials        127      127
Impacted Files Coverage Δ Complexity Δ
...query/autoconfigure/GraphQLJpaQueryProperties.java 85.71% <ø> (ø) 7 <0> (?)
...ry/autoconfigure/GraphQLShemaRegistrationImpl.java 100% <100%> (ø) 3 <3> (?)
...utoconfigure/GraphQLJpaQueryAutoConfiguration.java 100% <100%> (ø) 1 <0> (ø) ⬇️
.../query/autoconfigure/GraphQLSchemaFactoryBean.java 90% <100%> (+2.9%) 9 <3> (+2) ⬆️
.../autoconfigure/GraphQLSchemaAutoConfiguration.java 91.66% <100%> (+1.66%) 4 <2> (ø) ⬇️
...jpa/query/schema/impl/GraphQLJpaSchemaBuilder.java 87.12% <100%> (ø) 85 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0aa6c...cf4eca6. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #88 into master will decrease coverage by 0.22%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #88      +/-   ##
============================================
- Coverage     62.52%   62.29%   -0.23%     
  Complexity      314      314              
============================================
  Files            32       32              
  Lines          1900     1923      +23     
  Branches        286      286              
============================================
+ Hits           1188     1198      +10     
- Misses          585      598      +13     
  Partials        127      127
Impacted Files Coverage Δ Complexity Δ
...query/autoconfigure/GraphQLJpaQueryProperties.java 85.71% <ø> (ø) 7 <0> (?)
...ry/autoconfigure/GraphQLShemaRegistrationImpl.java 100% <100%> (ø) 3 <3> (?)
...utoconfigure/GraphQLJpaQueryAutoConfiguration.java 100% <100%> (ø) 1 <0> (ø) ⬇️
.../autoconfigure/GraphQLSchemaAutoConfiguration.java 91.66% <100%> (+1.66%) 4 <2> (ø) ⬇️
...jpa/query/schema/impl/GraphQLJpaSchemaBuilder.java 87.12% <100%> (ø) 85 <0> (ø) ⬇️
.../query/autoconfigure/GraphQLSchemaFactoryBean.java 74.13% <60%> (-12.96%) 9 <3> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0aa6c...fe03fc6. Read the comment docs.

@igdianov igdianov merged commit f838056 into master Mar 11, 2019
@igdianov igdianov deleted the fix-71-configuration-properties branch March 11, 2019 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration properties are ignored when merging
1 participant