SMS auth flow response of confirm verification code is invalid

[jpudysz]

Issue

Hello guys, I'm trying to implement signing with SMS provider and I found response mismatch.
If we try to confirm verification code we will get User object (like described in docs: https://rnfirebase.io/docs/v5.x.x/auth/reference/ConfirmationResult#confirm).
In my POV it's not correct, because it's not a added value and you're not passing more needed data like isNewUser flag.

As you can see in official Firebase docs this method should return UserCredentials (https://firebase.google.com/docs/reference/js/firebase.auth.ConfirmationResult#confirm)

I checked your native code and it's doable because you're passing only user object without additionalUserInfo (see the link to ios code: https://github.com/invertase/react-native-firebase/blob/master/packages/auth/ios/RNFBAuth/RNFBAuthModule.m#L728 and android: https://github.com/invertase/react-native-firebase/blob/master/packages/auth/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java#L956)

Hope it does make sense to you!

[mikehardy]

is that the response direct or the value you receive in onAuthChanged? I use the listener / onAuthChanged style and I believe I receive everything intended

[jpudysz]

This is the direct response from confirm method. There is no way to detect if user is new

[mikehardy]

in the onAuthChanged event handler the user is marked as new if new, as mentioned - I receive everything indicated I should using that method, which is also (I believe) the example code style on rnfirebase.io docs site - I recommend you try it, might work for you

[jpudysz]

@mikehardy unfortunately it won't work. As per documentation onAuthChanged callback is returning User object. User won't contain such information as isNewUser - please check the documentation (https://rnfirebase.io/docs/v5.x.x/auth/reference/User and https://firebase.google.com/docs/reference/js/firebase.User). We really need to return AdditionalUserInfo for confirm method because for now, it breaks the flow and its different for other providers.

[mikehardy]

I've read the docs, have you console.log'd the actual objects you receive in onAuthChanged? I am hand-waving / uncertain a bit because I haven't tested it just now but I know I have received objects with isNewUser set and I use this in my code even

[jpudysz]

@mikehardy sorry for delayed reply. onAuthChanged is returning user object without any additional flag (I console logged it). The problem is not related with onAuthChange as its working as expected and since v6 is almost ready and you're still migrating notifications please consider fixing the issue explained here and in other issue #2541 .

In short words:

• SMS provider flow is not consistent with other providers
• There is a bug - we can't signIn with credentials created with SMS provider described here: SMS code is always expired on real device iOS #2541 - I found a temporary solution but as I said above it's different than other provider flows

What you may consider to fix, before/in v6:

• add additionalUserInfo to confirm repsonse (for SMS provider)
• allow the developer to confirm the SMS code (right now it's confirmed somewhere underneath) and signIn manually is causing code to be expired

Thanks in advance!

[mikehardy]

Okay - I think I understand better now, thanks for the added information.

The misunderstanding on my part might be that I'm using the email sign in flow, and it contains isNewUser when I log it out - I had thought it was like that for all auth providers, and if I understand correctly you are saying that for SMS things are different?

If that's the case then this does seem like an area to work on.

Do note that v6 is in the final stretch for a 1.0 release and I don't believe auth will get a second pass before the firebase summit, however, development definitely won't just stop then it might just be a bit before items like this are re-shaped for follow-on releases

[mikehardy]

(I edited the title to conform to my new understanding, but it's possible if I didn't get the understanding correct the title is also incorrect - we can of course fix if that's the case)

[jpudysz]

Yup, you got it right!

The most important part which is not working (and I'm talking only about SMS provider, others are working as expected) and differs from official firebase is that

confirm(verificationCode)

is returning User but it should return UserCredentials (see my first post in this thread and link to react native firebase docs and official docs).

The second thing is crucial too, but less important:

I can't confirm user and signInWithCredential afterward because the user is signed in underneath (by React Native Firebase - I checked it with BrowserStack network debugger). It causes auth/code-expired described here: #2541 - and it's not consistent with other providers flow.

If you will have any additional questions, please let me know!
Thanks in advance

[mikehardy]

Excellent - thanks for confirming that. I'm surprised the different providers behave differently which is why it took me a bit to get over that and get to the understanding :-)

Maybe @Salakar or @Ehesp have context on why the SMS provider is different than the others - they would be the ones that could then move this forward by either providing that context or directing the change so that it conforms.

[stale]

Hello 👋, to help manage issues we automatically close stale issues.
This issue has been automatically marked as stale because it has not had activity for quite some time. Has this issue been fixed, or does it still require the community's attention?

This issue will be closed in 15 days if no further activity occurs.
Thank you for your contributions.

[stale]

Closing this issue after a prolonged period of inactivity. If this is still present in the latest release, please feel free to create a new issue with up-to-date information.