[v6] utils Logging #2526
Closed
[v6] utils Logging #2526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2526 +/- ##
==========================================
+ Coverage 88.78% 89.39% +0.61%
==========================================
Files 111 110 -1
Lines 3431 3279 -152
==========================================
- Hits 3046 2931 -115
+ Misses 385 348 -37 |
Ehesp
requested changes
Sep 4, 2019
docs/utils/quick-start.md
Outdated
| enableEventLogging: true, | ||
| }); | ||
|
|
||
| // config = { enableMethodLogging: true, enableEventLogging: ture } |
docs/utils/quick-start.md
Outdated
|
|
||
| ### Enable logging | ||
|
|
||
| You can enable logging for native method calls and event streams |
docs/utils/quick-start.md
Outdated
|
|
||
| ### Log out custom information | ||
|
|
||
| You can also use our built in logger to log your custom information |
| @@ -240,6 +240,7 @@ export namespace ReactNativeFirebase { | |||
| */ | |||
| export namespace Utils { | |||
| import FirebaseModule = ReactNativeFirebase.FirebaseModule; | |||
| type LoggerConfig = { enableMethodLogging: boolean; enableEventLogging: boolean }; | |||
There was a problem hiding this comment.
This will get added to the docs so worth having a quick description above it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress:
I tried to make it nice ¯_(ツ)_/¯