fix(analytics, ios): FirebaseAnalytics/Core is always needed
#8605
Conversation
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Oh no! I can see from the required change that I messed up the forward-port to the new dependencies from the rearrangement they did upstream, but I think the FirebaseAnalytics/Core dependency should be included unconditionally, outside of the if/else structure here.
What do you think of the suggestion I posted?
And in general, apologies, thought I'd gotten that one right but clearly not
| if defined?($RNFirebaseAnalyticsWithoutAdIdSupport) && ($RNFirebaseAnalyticsWithoutAdIdSupport == true) | ||
| Pod::UI.puts "#{s.name}: Not installing FirebaseAnalytics/IdentitySupport Pod, no IDFA will be collected." | ||
| s.dependency 'FirebaseAnalytics/Core', firebase_sdk_version |
There was a problem hiding this comment.
| if defined?($RNFirebaseAnalyticsWithoutAdIdSupport) && ($RNFirebaseAnalyticsWithoutAdIdSupport == true) | |
| Pod::UI.puts "#{s.name}: Not installing FirebaseAnalytics/IdentitySupport Pod, no IDFA will be collected." | |
| s.dependency 'FirebaseAnalytics/Core', firebase_sdk_version | |
| s.dependency 'FirebaseAnalytics/Core', firebase_sdk_version | |
| if defined?($RNFirebaseAnalyticsWithoutAdIdSupport) && ($RNFirebaseAnalyticsWithoutAdIdSupport == true) | |
| Pod::UI.puts "#{s.name}: Not installing FirebaseAnalytics/IdentitySupport Pod, no IDFA will be collected." |
There was a problem hiding this comment.
Sorry, in this commentary wrote to use 'Default', 'Core'(w/o AdId) or 'IdentitySupport'(w/ AdId). I don't understand when needs to apply 'Default' variant.
I just replaced previous removed deprecated Firebase/AnalyticsWithoutAdIdSupport with FirebaseAnalytics/Core, because it recommended to use instead of deprecated package.
There was a problem hiding this comment.
Okay - I've got this patched up and pushed it back out - will merge when CI goes green
Sorry again for this - thanks to you and @radko93 for posting up PRs to fix the error
Will release shortly after CI is green
mikehardy
added
Workflow: Waiting for User Response
the IdentitySupport case works without this Core pod specified because of transitive dependencies, but the no-IDFA case (*very* important for those that need it) failed to include it causing broken builds Co-authored-by: Mike Hardy <[email protected]>
mikehardy
changed the title
FirebaseAnalytics/Core is always needed
mikehardy
removed
the
Workflow: Waiting for User Response
Description
Fix issue on app assembling, when option
$RNFirebaseAnalyticsWithoutAdIdSupport = truein Podfile.Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter