fix(mm): only add suffix to model paths when path is file #8413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that diffusers/folder models with a
.
in the model source had everything after the.
appended to their destination path.Example model:
This model's source ends with
.0
. It was installed intosdxl/controlnet/Depth Map.0
, when it should be installed tosdxl/controlnet/Depth Map
.I added an extra check to only add the suffix to the destination path when the model is a file. Single-file models still get the correct file extension and folders use the preferred name.
Related Issues / Discussions
This is a follow-on to #8352. It's been an issue for a long time.
QA Instructions
I used the SDXL Depth Map and CyberRealistic models as tests for this. They isntall to the correct locations.
Merge Plan
n/a
Checklist
What's New
copy (if doing a release after this PR)