fix(mm): fail when model exists at path instead of finding unused new path #8419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant and
hipsterusername
as code owners
github-actions
bot
added
python
hipsterusername
approved these changes
Aug 12, 2025
… path When installing a model, the previous, graceful logic would increment a suffix on the destination path until found a free path for the model. But because model file installation and record creation are not in a transaction, we could end up moving the file successfully and fail to create the record: - User attempts to install an already-installed model - Attempt to move the downloaded model from download tempdir to destination path - The path already exists - Add `_1` or similar to the path until we find a path that is free - Move the model - Create the model record - FK constraint violation bc we already have a model w/ that name, but the model file has already been moved into the invokeai dir. Closes #8416
psychedelicious
force-pushed
the
psyche/fix/duplicate-model-during-install
branch
from
8d611da to
b56ca88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When installing a model, the previous, graceful logic would increment a suffix on the destination path until found a free path for the model.
But because model file installation and record creation are not in a transaction, we could end up moving the file successfully and fail to create the record:
_1or similar to the path until we find a path that is freeRelated Issues / Discussions
Closes #8416
QA Instructions
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)