Skip to content

fix(ui): fit to bbox when bbox is not aligned to 64px grid #8439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

fix(ui): fit to bbox when bbox is not aligned to 64px grid #8439

merged 1 commit into from
Aug 18, 2025

Conversation

psychedelicious
Copy link
Collaborator

@psychedelicious psychedelicious commented Aug 18, 2025 •
edited
Loading

Summary

Fix issue where layer could end up positioned incorrectly when fitting to bbox and bbox is not aligned to 64px grid

Related Issues / Discussions

Reported by @dunkeroni : https://discord.com/channels/1020123559063990373/1149506274971631688/1406520938195062925

QA Instructions

I tested all permutations of this matrix:

  • Grid alignment: bbox origin aligned to 64px grid or not (hold cmd when moving bbox to move in 8px increments and break alignment)
  • Bbox aspect ratio: portrait/landscape/square
  • Layer aspect ratio: portrait/landscape/square

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the frontend PRs that change frontend files label Aug 18, 2025
@psychedelicious psychedelicious enabled auto-merge (rebase) August 18, 2025 13:15
@psychedelicious psychedelicious merged commit 6d18a72 into main Aug 18, 2025
12 checks passed
@psychedelicious psychedelicious deleted the psyche/fix/fit-to-bbox branch August 18, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psychedelicious @hipsterusername