Skip to content

Conversation

psychedelicious
Copy link
Collaborator

Summary

  • Do not attempt to cache nodes without width or height. Prevents a console error from being logged by Konva. This particular error wasn't ever raised - just logged. So this only reduces some noise.
  • Log at error level when an image fails to load. Previously, this log was accidentally done without specifying a log level, which apparently results in no logs at all.
  • Include the specific error when an image fails to load. Previously, only a message "unable to load image" was logged.

Related Issues / Discussions

n/a

QA Instructions

n/a

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the frontend PRs that change frontend files label Aug 28, 2025
@psychedelicious psychedelicious enabled auto-merge (rebase) August 28, 2025 02:56
@psychedelicious psychedelicious force-pushed the psyche/fix/ui/konva-errors branch from 6ea177b to a109c88 Compare August 28, 2025 02:56
@psychedelicious psychedelicious merged commit 0de1fee into main Aug 28, 2025
13 checks passed
@psychedelicious psychedelicious deleted the psyche/fix/ui/konva-errors branch August 28, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants