fix(app): FLUX on Windows hard crash #8494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A recent update to
sentencepiece
causes a hard crash in Windows. The crash occurs whentransformers
attempts to load the vocab viasentencepiece
: https://github.com/huggingface/transformers/blame/b824f4986f9c13faffac1df016ae663e00adc755/src/transformers/models/t5/tokenization_t5.py#L150I will try to create a minimal repro for
sentencepiece
later.Related Issues / Discussions
Closes #8486
QA Instructions
You can test this on Windows by manually downloading
sentencepiece
. Open the Launcher's Dev Console and run:Then start Invoke and generate with FLUX.
I also tested by building the wheel based on this branch in CI (this run) and installing it via Dev Console like this:
Merge Plan
Will do a patch release.
Checklist
What's New
copy (if doing a release after this PR)