fix(ui): browser image caching cors race condition #8523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
maryhipp
approved these changes
Sep 3, 2025
psychedelicious
force-pushed
the
psyche/fix/ui/cors-race
branch
from
e4753b0 to
56dced7
Compare
Must set cross origin whenever we load an image from a URL to prevent race conditions where browser caches an image with no CORS, then canvas attempts to load it with CORS, resulting in browser rejecting the request before it is made
psychedelicious
force-pushed
the
psyche/fix/ui/cors-race
branch
from
56dced7 to
7b97f6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Must set cross origin whenever we load an image from a URL to prevent race conditions where browser caches an image with no CORS, then canvas attempts to load it with CORS, resulting in browser rejecting the request before it is made
Related Issues / Discussions
n/a
QA Instructions
n/a
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)