Skip to content

Revert "tidy(ui): translation cleanup and CI checks" #8539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 8, 2025
Merged

Revert "tidy(ui): translation cleanup and CI checks" #8539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4657d48
Revert "tidy(ui): remove python clean translations script"
psychedelicious Sep 5, 2025
a7b875b
Revert "chore(ui): clean translations"
psychedelicious Sep 5, 2025
9fe0ca8
Revert "ci: add translation string check to frontend checks"
psychedelicious Sep 5, 2025
3ffd8d9
Revert "build(ui): add package script to check and clean translatoins"
psychedelicious Sep 5, 2025
4fde8e8
Revert "build(ui): port clean translations script to js"
psychedelicious Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions .github/workflows/frontend-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,20 +83,3 @@ jobs:
if: ${{ steps.changed-files.outputs.frontend_any_changed == 'true' || inputs.always_run == true }}
run: 'pnpm lint:knip'
shell: bash

- name: translations
if: ${{ steps.changed-files.outputs.frontend_any_changed == 'true' || inputs.always_run == true }}
run: |
echo "Checking for unused translations..."
if ! pnpm translations:check; then
echo ""
echo "❌ Translation file contains unused keys!"
echo ""
echo "To fix this, run:"
echo " pnpm translations:clean"
echo " pnpm fix"
echo ""
echo "Then commit the changes."
exit 1
fi
shell: bash
4 changes: 1 addition & 3 deletions invokeai/frontend/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@
"build-storybook": "storybook build",
"test": "vitest",
"test:ui": "vitest --coverage --ui",
"test:no-watch": "vitest --no-watch",
"translations:check": "node scripts/clean-translations.js public/locales/en.json --mode check",
"translations:clean": "node scripts/clean-translations.js public/locales/en.json --mode clean"
"test:no-watch": "vitest --no-watch"
},
"dependencies": {
"@atlaskit/pragmatic-drag-and-drop": "^1.7.4",
Expand Down
Loading