feat(playground): pass the variables theming file to StackBlitz #2602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
variables.css
file to the angular, javascript (html), react and vue directories.display.css
to the react, javascript and angular css imports.variables.css
file to StackBlitz in a folder calledtheme
Issue found:
When viewing the website in light mode, then opening a StackBlitz (any language) while the system is set to prefer dark mode, it will display the StackBlitz example in dark mode. This is working as intended based on the content in the
variable.css
file, but it may be unexpected for users since the website is not automatically displayed in dark mode until you toggle the dark theme. Should we change this so it checks what mode the user is in on the website?Chip is a pretty good example of this: https://ionic-docs-git-fw-1666-ionic1.vercel.app/docs/api/chip