Skip to content

fix(playground): warn if version not specified #2668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 27, 2023
Merged

Conversation

sean-perkins
Copy link
Contributor

  • Statically assigns the version for the v6 playground examples
  • Removes the default version value for the <Playground /> component
    • Not providing a version will result in a warning in the console.

Note: In the previous PR I incorrectly had the version typed applied to the UsageTargetOptions, instead of the playground properties.

@vercel
Copy link

vercel bot commented Dec 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 9:44PM (UTC)

@sean-perkins sean-perkins marked this pull request as ready for review December 7, 2022 23:19
@sean-perkins sean-perkins requested a review from a team December 7, 2022 23:19
Base automatically changed from release-7.0 to main January 25, 2023 15:17
@averyjohnston
Copy link
Contributor

@sean-perkins Any blockers here? I forgot to add the version to my datetime playgrounds in a previous PR, so this warning would be useful to have.

@sean-perkins
Copy link
Contributor Author

This one slipped on my end. I'll rebase and validate it continues to function as expected before merging 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants