Skip to content

Update modal-example_component_ts.md #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

BlackHakwDC
Copy link
Contributor

fix failure in type-ahead::search

@vercel
Copy link

vercel bot commented Mar 15, 2023

@BlackHakwDC is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

@liamdebeasi
Copy link
Contributor

Thanks for the PR! Can you please describe the issue that this resolves?

@BlackHakwDC
Copy link
Contributor Author

The search has 2 errors.

  1. It searches in the value properties of the displayed objects. However, the user does not see the values but the label properties. This means that the search result is not comprehensible for him.

  2. If you normalise the query, which is correct, you must also normalise the values to be searched, otherwise you will not find any results.

@liamdebeasi
Copy link
Contributor

Makes sense, thanks! This code is used in several other places since we use this for other JS frameworks too. I'll work on making these other changes.

@liamdebeasi
Copy link
Contributor

Hey there,

I merged this fix in #2840 and gave you co-author credit. I am going to close this PR in favor of the merged PR. Thanks again for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants