Skip to content

docs(select): fix typeahead search #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2023
Merged

docs(select): fix typeahead search #2840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5373183
docs(select): fix typeahead search
liamdebeasi Mar 21, 2023
11279a4
Update demo.html
liamdebeasi Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/usage/v6/select/typeahead/angular/modal-example_component_ts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export class TypeaheadComponent implements OnInit {
*/
const normalizedQuery = searchQuery.toLowerCase();
this.filteredItems = this.items.filter(item => {
return item.value.includes(normalizedQuery);
return item.text.toLowerCase().includes(normalizedQuery);
});
}
}
Expand Down
2 changes: 1 addition & 1 deletion static/usage/v6/select/typeahead/demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@

const normalizedQuery = searchQuery.toLowerCase();

return fruits.filter(fruit => fruit.value.includes(normalizedQuery));
return fruits.filter(fruit => fruit.text.toLowerCase().includes(normalizedQuery));
}

/**
Expand Down
2 changes: 1 addition & 1 deletion static/usage/v6/select/typeahead/javascript.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@

const normalizedQuery = searchQuery.toLowerCase();

return fruits.filter(fruit => fruit.value.includes(normalizedQuery));
return fruits.filter(fruit => fruit.text.toLowerCase().includes(normalizedQuery));
}

/**
Expand Down
2 changes: 1 addition & 1 deletion static/usage/v6/select/typeahead/react/typeahead_component_tsx.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ function AppTypeahead(props: TypeaheadProps) {
*/
const normalizedQuery = searchQuery.toLowerCase();
setFilteredItems(props.items.filter(item => {
return item.value.includes(normalizedQuery);
return item.text.toLowerCase().includes(normalizedQuery);
}));
}
}
Expand Down
2 changes: 1 addition & 1 deletion static/usage/v6/select/typeahead/vue/typeahead_component_vue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
*/
const normalizedQuery = searchQuery.toLowerCase();
filteredItems.value = props.items.filter(item => {
return item.value.includes(normalizedQuery);
return item.text.toLowerCase().includes(normalizedQuery);
});
}
}
Expand Down
4 changes: 2 additions & 2 deletions static/usage/v7/select/typeahead/angular/modal-example_component_ts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { Item } from './types';
selector: 'app-typeahead',
templateUrl: 'typeahead.component.html',
})
export class TypeaheadComponentt implements OnInit {
export class TypeaheadComponent implements OnInit {
@Input() items: Item[] = [];
@Input() selectedItems: string[] = [];
@Input() title = 'Select Items';
Expand Down Expand Up @@ -60,7 +60,7 @@ export class TypeaheadComponentt implements OnInit {
*/
const normalizedQuery = searchQuery.toLowerCase();
this.filteredItems = this.items.filter(item => {
return item.value.includes(normalizedQuery);
return item.text.toLowerCase().includes(normalizedQuery);
});
}
}
Expand Down
4 changes: 2 additions & 2 deletions static/usage/v7/select/typeahead/demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<body>
<ion-app>
<ion-content color="light">
<div class="container">
<div class="container">
<ion-list inset="true">
<ion-item button="true" detail="false" id="select-fruits">
<ion-label>Favorite Fruits</ion-label>
Expand Down Expand Up @@ -108,7 +108,7 @@

const normalizedQuery = searchQuery.toLowerCase();

return fruits.filter(fruit => fruit.value.includes(normalizedQuery));
return fruits.filter(fruit => fruit.text.toLowerCase().includes(normalizedQuery));
}

/**
Expand Down
2 changes: 1 addition & 1 deletion static/usage/v7/select/typeahead/javascript.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@

const normalizedQuery = searchQuery.toLowerCase();

return fruits.filter(fruit => fruit.value.includes(normalizedQuery));
return fruits.filter(fruit => fruit.text.toLowerCase().includes(normalizedQuery));
}

/**
Expand Down
2 changes: 1 addition & 1 deletion static/usage/v7/select/typeahead/react/typeahead_component_tsx.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ function AppTypeahead(props: TypeaheadProps) {
*/
const normalizedQuery = searchQuery.toLowerCase();
setFilteredItems(props.items.filter(item => {
return item.value.includes(normalizedQuery);
return item.text.toLowerCase().includes(normalizedQuery);
}));
}
}
Expand Down
2 changes: 1 addition & 1 deletion static/usage/v7/select/typeahead/vue/typeahead_component_vue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
*/
const normalizedQuery = searchQuery.toLowerCase();
filteredItems.value = props.items.filter(item => {
return item.value.includes(normalizedQuery);
return item.text.toLowerCase().includes(normalizedQuery);
});
}
}
Expand Down