Skip to content

fix(generation): correct angular imports #3034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2023
Merged

fix(generation): correct angular imports #3034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3000cb5
Refactor: Improve readability
mapsandapps Jul 12, 2023
68a408a
Combine index files and fix bug with angular ts generation
mapsandapps Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions _templates/playground/new/angular_example_component_ts.md.ejs.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@ import { Component } from '@angular/core';

@Component({
selector: 'app-example',
templateUrl: 'example.component.html',<% if (css){ %>
styleUrls: ['./example.component.css'],<% } %>
templateUrl: 'example.component.html',
<% if (css){ -%>
styleUrls: ['./example.component.css'],
<% } -%>
})
export class ExampleComponent {
}
Expand Down
53 changes: 50 additions & 3 deletions _templates/playground/new/index.md.ejs.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,60 @@
---
arbitrary: <% nameWithoutIon = name.replace('ion-', '') %>
# this template is only used if `css` (from the command line prompt) is false
to: "<%= css ? null : `static/usage/v${version}/${nameWithoutIon}/${path}/index.md` %>"
to: "<%= `static/usage/v${version}/${nameWithoutIon}/${path}/index.md` %>"
---
import Playground from '@site/src/components/global/Playground';

import javascript from './javascript.md';
<% if (css){ %>
import react_main_tsx from './react/main_tsx.md';
import react_main_css from './react/main_css.md';

<% } else { -%>
import react from './react.md';
<% } -%>
import vue from './vue.md';
<% if (css || angular_ts){ %>
import angular_example_component_html from './angular/example_component_html.md';
<% } else { -%>
import angular from './angular.md';
<% } -%>
<% if (angular_ts){ -%>
import angular_example_component_ts from './angular/example_component_ts.md';
<% } -%>
<% if (css){ -%>
import angular_example_component_css from './angular/example_component_css.md';
<% } -%>

<Playground version="<%= version %>" code={{ javascript, react, vue, angular }} src="<%= `usage/v${version}/${nameWithoutIon}/${path}/demo.html` %>" />
<Playground
version="<%= version %>"
code={{
javascript,
<% if (css){ -%>
react: {
files: {
'src/main.tsx': react_main_tsx,
'src/main.css': react_main_css,
},
},
<% } else { -%>
react,
<% } -%>
vue,
<% if (angular_ts || css){ -%>
angular: {
files: {
'src/app/example.component.html': angular_example_component_html,
<% if (angular_ts){ -%>
'src/app/example.component.ts': angular_example_component_ts,
<% } -%>
<% if (css){ -%>
'src/app/example.component.css': angular_example_component_css,
<% } -%>
},
},
<% } else { -%>
angular,
<% } -%>
}}
src="usage/v<%= version %>/<%= nameWithoutIon %>/<%= path %>/demo.html"
/>
37 changes: 0 additions & 37 deletions _templates/playground/new/index_with_css.md.ejs.t
View file
Open in desktop

This file was deleted.

6 changes: 4 additions & 2 deletions _templates/playground/new/javascript.md.ejs.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@
to: "<%= `static/usage/v${version}/${name.replace('ion-', '')}/${path}/javascript.md` %>"
---
```html
<<%= name %>></<%= name %>><% if (css){ %>
<<%= name %>></<%= name %>>
<% if (css){ -%>

<style>
<%= name %> {
/* styles go here */
}
</style><% } %>
</style>
<% } -%>
```
6 changes: 4 additions & 2 deletions _templates/playground/new/vue.md.ejs.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,13 @@ to: "<%= `static/usage/v${version}/${name.replace('ion-', '')}/${path}/vue.md` %
<%= pascalName %>,
},
});
</script><% if (css){ %>
</script>
<% if (css){ -%>

<style scoped>
<%= name %> {
/* styles go here */
}
</style><% } %>
</style>
<% } -%>
```