Skip to content

fix(dark-mode): demos use correct stepped color tokens #3495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix(dark-mode): demos use correct stepped color tokens #3495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions static/usage/v8/theming/always-dark-mode/demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,19 +61,19 @@
<style>
/* This sets a different item border color for the default theme on ios and md */
:root {
--ion-item-border-color: var(--ion-color-step-200);
--ion-item-border-color: var(--ion-background-color-step-200);
}

/* This sets a different background and item background for the default theme on ios */
:root.ios {
--ion-background-color: var(--ion-color-step-50);
--ion-background-color: var(--ion-background-color-step-50);
--ion-toolbar-background: var(--ion-background-color);
--ion-item-background: #1c1c1d;
}

/* This sets a different background and item background for the default theme on md */
:root.md {
--ion-background-color: var(--ion-color-step-100);
--ion-background-color: var(--ion-background-color-step-100);
--ion-toolbar-background: var(--ion-background-color);
--ion-item-background: #1c1c1d;
}
Expand Down
6 changes: 3 additions & 3 deletions static/usage/v8/theming/class-dark-mode/demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,19 +123,19 @@

/* This sets a different item border color for the default theme on ios and md */
:root {
--ion-item-border-color: var(--ion-color-step-200);
--ion-item-border-color: var(--ion-background-color-step-200);
}

/* This sets a different background and item background for the default theme on ios */
:root.ios {
--ion-background-color: var(--ion-color-step-50, #f2f2f6);
--ion-background-color: var(--ion-background-color-step-50, #f2f2f6);
--ion-toolbar-background: var(--ion-background-color);
--ion-item-background: #fff;
}

/* This sets a different background and item background for the default theme on md */
:root.md {
--ion-background-color: var(--ion-color-step-100, #f9f9f9);
--ion-background-color: var(--ion-background-color-step-100, #f9f9f9);
--ion-toolbar-background: var(--ion-background-color);
--ion-item-background: #fff;
}
Expand Down
6 changes: 3 additions & 3 deletions static/usage/v8/theming/system-dark-mode/demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,19 +66,19 @@

/* This sets a different item border color for the default theme on ios and md */
:root {
--ion-item-border-color: var(--ion-color-step-200);
--ion-item-border-color: var(--ion-background-color-step-200);
}

/* This sets a different background and item background for the default theme on ios */
:root.ios {
--ion-background-color: var(--ion-color-step-50, #f2f2f6);
--ion-background-color: var(--ion-background-color-step-50, #f2f2f6);
--ion-toolbar-background: var(--ion-background-color);
--ion-item-background: #fff;
}

/* This sets a different background and item background for the default theme on md */
:root.md {
--ion-background-color: var(--ion-color-step-100, #f9f9f9);
--ion-background-color: var(--ion-background-color-step-100, #f9f9f9);
--ion-toolbar-background: var(--ion-background-color);
--ion-item-background: #fff;
}
Expand Down