Skip to content

docs(playgrounds): fix cdn imports to target v8 #4118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented May 19, 2025

There are a few paths targeting core@next which should be core@8. See the differences here:

static/code/stackblitz/v8/html/index.withContent.html
static/code/stackblitz/v8/html/index.html

The files above are both used by the JavaScript StackBlitz examples but target different npm tags for core.

Copy link

vercel bot commented May 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 9:26pm

@brandyscarney brandyscarney marked this pull request as ready for review May 19, 2025 21:26
@brandyscarney brandyscarney requested a review from a team as a code owner May 19, 2025 21:26
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@brandyscarney brandyscarney merged commit df6c181 into main May 20, 2025
4 checks passed
@brandyscarney brandyscarney deleted the bc/fix-script-version branch May 20, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants