Skip to content

Commit 92b13c2

Browse files
authored
chore: highlight variables are deprecated (#27987)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> There was some confusion on #27985 as to how the `--highlight-*` variables on `ion-item` apply to the modern form controls. These variables only work with the legacy form syntax, but we did not add a proper deprecation message. `--highlight-*` variables have been added to `ion-input` and `ion-textarea` instead so developers can customize the highlight when using the modern form syntax. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Deprecated the `--highlight-*` variables on `ion-item`. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
1 parent e5a02f4 commit 92b13c2

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

core/src/components/item/item.scss

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
// Item
44
// --------------------------------------------------
5+
// TODO: FW-4955
56

67
:host {
78
/**
@@ -45,10 +46,10 @@
4546
*
4647
* @prop --ripple-color: Color of the item ripple effect
4748
*
48-
* @prop --highlight-height: The height of the highlight on the item
49-
* @prop --highlight-color-focused: The color of the highlight on the item when focused
50-
* @prop --highlight-color-valid: The color of the highlight on the item when valid
51-
* @prop --highlight-color-invalid: The color of the highlight on the item when invalid
49+
* @prop --highlight-height: The height of the highlight on the item. Only applies to inputs and textareas using the legacy form syntax. DEPRECATED: Highlights can be styled on `ion-input` or `ion-textarea` when using the modern form syntax.
50+
* @prop --highlight-color-focused: The color of the highlight on the item when focused. Only applies to inputs and textareas using the legacy form syntax. DEPRECATED: Highlights can be styled on `ion-input` or `ion-textarea` when using the modern form syntax.
51+
* @prop --highlight-color-valid: The color of the highlight on the item when valid. Only applies to inputs and textareas using the legacy form syntax. DEPRECATED: Highlights can be styled on `ion-input` or `ion-textarea` when using the modern form syntax.
52+
* @prop --highlight-color-invalid: The color of the highlight on the item when invalid. Only applies to inputs and textareas using the legacy form syntax. DEPRECATED: Highlights can be styled on `ion-input` or `ion-textarea` when using the modern form syntax.
5253
*/
5354
--border-radius: 0px;
5455
--border-width: 0px;

0 commit comments

Comments
 (0)