Skip to content

chore: highlight variables are deprecated #27987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Aug 14, 2023

Issue number: N/A


What is the current behavior?

There was some confusion on #27985 as to how the --highlight-* variables on ion-item apply to the modern form controls. These variables only work with the legacy form syntax, but we did not add a proper deprecation message.

--highlight-* variables have been added to ion-input and ion-textarea instead so developers can customize the highlight when using the modern form syntax.

What is the new behavior?

  • Deprecated the --highlight-* variables on ion-item.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@liamdebeasi liamdebeasi marked this pull request as ready for review August 14, 2023 14:19
@liamdebeasi liamdebeasi enabled auto-merge August 14, 2023 14:19
@liamdebeasi liamdebeasi requested review from a team and thetaPC and removed request for a team August 14, 2023 14:19
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liamdebeasi liamdebeasi added this pull request to the merge queue Aug 14, 2023
Merged via the queue into main with commit 92b13c2 Aug 14, 2023
@liamdebeasi liamdebeasi deleted the deprecate-item-vars branch August 14, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants