Skip to content

perf: Collection repeat memory leak #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
85lele opened this issue Jun 26, 2015 · 3 comments
Closed

perf: Collection repeat memory leak #3999

85lele opened this issue Jun 26, 2015 · 3 comments

Comments

@85lele
Copy link

85lele commented Jun 26, 2015

Type: perf

Platform: all

In the destroy function of collection-repeat directive, computedStyleNode never has a parent.

Moreover using removeChild just detach the node, but it doesn't remove events attached on it (or on childs) by other directives (like ng-click).
This causes the detached DOM of the scroll view to be kept in memory.

If I replace it with angular.element(computedStyleNode).remove(); all works fine.

@Ionitron
Copy link
Collaborator

Greetings @85lele!

I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.

Thank you for allowing me to assist you.

@timestep
Copy link

Can this issue be reopened? This seems to be a simple solution to a very common problem, and can provide huge value.

@yossi-shasho
Copy link

+1

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants