-
Notifications
You must be signed in to change notification settings - Fork 13.5k
feat(spinner): updated styles for latest iOS #22397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ionic Latest
Merge latest master
latest ionic
latest ionic
latest ionic
Thanks for the PR. If we are going to ship this as the new default, we are going to need to revise how
@brandyscarney I do think we need this change for the iOS 14 design revisions, but do you think this should be the new default or a separate option? |
@liamdebeasi i also created this PR: #22398 - i think the changes you mentioned should be done there? |
@liamdebeasi i did the both changes that u mentioned in the refresher PR #22398 😊 In combination with this PR here, if u merge both together, the native Pull-To-Refresh will look like this (slowed down): |
@liamdebeasi - what the process to get this PR and #22398 reviewed and merged? |
@rgoldiez as far as i know are ios14 design changes planned for Version 6 |
I made a few changes to your PR, but I think this is ready to merge. The biggest change is we added back the old spinner style under the |
Merged. Thank you! |
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Update the ion-spinner
lines
&lines-small
to match latest iOS changesIssue Number: resolves #22782
What is the new behavior?
fn()
adjusted to work withtotal
Does this introduce a breaking change?