Skip to content

feat(spinner): updated styles for latest iOS #22397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Feb 11, 2021
Merged

feat(spinner): updated styles for latest iOS #22397

merged 21 commits into from
Feb 11, 2021

Conversation

EinfachHans
Copy link
Contributor

@EinfachHans EinfachHans commented Oct 27, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Update the ion-spinner lines & lines-small to match latest iOS changes

Issue Number: resolves #22782

What is the new behavior?

  • 8 lines instead of 12
  • fn() adjusted to work with total
  • stroke-width increased

Does this introduce a breaking change?

  • Yes
  • No

@liamdebeasi
Copy link
Contributor

Thanks for the PR. If we are going to ship this as the new default, we are going to need to revise how ion-refresher works too. Two things stick out in that regard:

  1. The default spinner color is gray instead of dark gray/black in pull to refresh on native iOS (see Mail app)
  2. The tick marks all progressively fade in rather than appear as you pull.

@brandyscarney I do think we need this change for the iOS 14 design revisions, but do you think this should be the new default or a separate option?

@EinfachHans
Copy link
Contributor Author

@liamdebeasi i also created this PR: #22398 - i think the changes you mentioned should be done there?

@EinfachHans
Copy link
Contributor Author

@liamdebeasi i did the both changes that u mentioned in the refresher PR #22398 😊

In combination with this PR here, if u merge both together, the native Pull-To-Refresh will look like this (slowed down):

@rgoldiez
Copy link

rgoldiez commented Dec 4, 2020

@liamdebeasi - what the process to get this PR and #22398 reviewed and merged?

@EinfachHans
Copy link
Contributor Author

@rgoldiez as far as i know are ios14 design changes planned for Version 6

@liamdebeasi liamdebeasi changed the base branch from master to next February 11, 2021 14:56
@liamdebeasi
Copy link
Contributor

I made a few changes to your PR, but I think this is ready to merge. The biggest change is we added back the old spinner style under the lines-sharp and lines-sharp-small values for those who prefer the less iOS-like spinner style.

@liamdebeasi liamdebeasi merged commit 2a5b272 into ionic-team:next Feb 11, 2021
@liamdebeasi
Copy link
Contributor

Merged. Thank you!

@EinfachHans EinfachHans deleted the issue-22148 branch February 12, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: update default ion-spinner to match the latest ios 14 style
3 participants