Skip to content

refactor(ios): update toolbar and tabbar default background colors #22852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 9, 2021

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Feb 1, 2021

Starters: ionic-team/starters#1670
Docs: ionic-team/ionic-docs#1835

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #22780

What is the new behavior?

  • Updated toolbar and tab bar default background colors (fallback values)

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Feb 1, 2021
@liamdebeasi
Copy link
Contributor Author

liamdebeasi commented Feb 1, 2021

Large Title

Light - Collapsed toolbar has changed from white to light gray
Dark - No changes

before after
light image image
dark image image

Toolbar

Light - Header and footer toolbars have changed from white to light gray
Dark - No changes

before after
light image image
dark image image

Tabbar

Light - Tab bar background has changed from white to light gray
Dark - Tab bar background has changed from black to dark gray

before after
light b-tab-ios-l image
dark image image

@liamdebeasi liamdebeasi changed the title breaking(ios): update toolbar and tabbar default background colors refactor(ios): update toolbar and tabbar default background colors Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant